Skip to content

Add dependencies removed from default gems in Ruby 3.4.0#400

Closed
sparr wants to merge 1 commit intoandymeneely:devfrom
sparr:add_deps_ruby_3.4.0
Closed

Add dependencies removed from default gems in Ruby 3.4.0#400
sparr wants to merge 1 commit intoandymeneely:devfrom
sparr:add_deps_ruby_3.4.0

Conversation

@sparr
Copy link
Contributor

@sparr sparr commented Sep 3, 2025

Motivation

Ruby 3.4.0 removed a bunch of default gems. The ones used by squib need to be specified.

/usr/lib/ruby/3.4.0/did_you_mean/core_ext/name_error.rb:11: warning: bigdecimal is not part of the default gems starting from Ruby 3.4.0. Install bigdecimal from RubyGems.
<internal:/usr/lib/ruby/3.4.0/rubygems/core_ext/kernel_require.rb>:136:in 'Kernel#require': cannot load such file -- bigdecimal (LoadError)
        from <internal:/usr/lib/ruby/3.4.0/rubygems/core_ext/kernel_require.rb>:136:in 'Kernel#require'
        from /home/sparr/.local/share/gem/ruby/3.4.0/gems/squib-0.19.0/lib/squib/commands/make_sprue.rb:4:in '<top (required)>'

/usr/lib/ruby/3.4.0/did_you_mean/core_ext/name_error.rb:11: warning: csv is not part of the default gems starting from Ruby 3.4.0. Install csv from RubyGems.
<internal:/usr/lib/ruby/3.4.0/rubygems/core_ext/kernel_require.rb>:136:in 'Kernel#require': cannot load such file -- csv (LoadError)
        from <internal:/usr/lib/ruby/3.4.0/rubygems/core_ext/kernel_require.rb>:136:in 'Kernel#require'
        from /home/sparr/.local/share/gem/ruby/3.4.0/gems/squib-0.19.0/lib/squib/args/csv_opts.rb:1:in '<top (required)>'

I also included abbrev which is a new dependency of highline. I opened an issue for them to backport their dependency fix to version 2.1 but that's a long shot. JEG2/highline#280

@sparr sparr force-pushed the add_deps_ruby_3.4.0 branch from f63ff9a to 505ed0c Compare September 3, 2025 18:30
@sparr sparr force-pushed the add_deps_ruby_3.4.0 branch from 505ed0c to 8646604 Compare September 3, 2025 18:35
@sparr sparr marked this pull request as draft September 3, 2025 18:35
@sparr sparr marked this pull request as ready for review September 3, 2025 18:35
@sparr
Copy link
Contributor Author

sparr commented Sep 3, 2025

This PR failed tests due to Ruby 3.1 perceiving duplicate dependencies on the then-default gems. I pushed some attempts to address that, but now Github has stopped running checks on the PR?

@abinoam abinoam mentioned this pull request Sep 3, 2025
Open
@sparr
Copy link
Contributor Author

sparr commented Sep 4, 2025

I accidentally started working from master, not dev.

@sparr sparr closed this Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sparr